Support Grain with Tfrecord in train_tokenizer#3522
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 2, 2026
Merged
Support Grain with Tfrecord in train_tokenizer#3522copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
aireenmei
force-pushed
the
aireen/train_tokenizer_tfrecord
branch
from
bd59abe to
94f2da2
Compare
aireenmei
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
NuojCheng
approved these changes
Mar 31, 2026
aireenmei
force-pushed
the
aireen/train_tokenizer_tfrecord
branch
from
94f2da2 to
30dd96e
Compare
SurbhiJainUSC
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
train_tokenizer.pyalready supports training with Grain in arrayrecord or parquet formats. Add support for tfrecordTests
Add
TrainTokenizerFormatTestin tokenizer_test.py to test all 3 formatsChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.